Open
Conversation
Signed-off-by: Junya Okabe <junya.okabe.ig@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Okabe-Junya
added
the
maintainers
nate-double-u
approved these changes
Mar 4, 2026
Member
|
Sorry, i know this is still a draft. But if the goal is to bump node, i think it's good. |
Okabe-Junya
requested review from
caniszczyk,
jihoon-seo and
seokho-son
as code owners
Collaborator
Author
|
Ah, sorry I completely forgot about this PR... (and probably just forgot to mark this PR as "ready for review") |
nate-double-u
previously requested changes
Mar 6, 2026
Member
nate-double-u
left a comment
nate-double-u
left a comment
There was a problem hiding this comment.
Looking a bit closer, I think we need to update one more bit:
Line 6 in 72d5d4a
Collaborator
Author
|
Thanks, good pointing out! |
Signed-off-by: Junya Okabe <junya.okabe.ig@gmail.com>
nate-double-u
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related issue number or link (ex:
resolves #issue-number)follow-up #3599 (comment)
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".