Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect issue#564
Merged
brookslogan merged 28 commits intodevfrom Dec 9, 2024
Merged
Conversation
7a8ec75 to
85503c1
Compare
1627870 to
e6f7264
Compare
Contributor
Author
|
e6f7264 to
6a22c4b
Compare
- BREAKING CHANGE: adjust default output column naming scheme, disallow overwriting columns.
882e960 to
9669773
Compare
fdc9ee7 to
79ed2f3
Compare
- Show naming options, including with multi-column selections when we have accommodating example data sets - Select away the pre-existing 7d aggregations in the example data set - Ungroup output
845f4c0 to
beb434c
Compare
45170b1 to
f9a8356
Compare
ed23df0 to
6d8bcf6
Compare
epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect bug
epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect bugepi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect issue
We may later need it to make default args, in which case we should probably export to be less "magical".
Contributor
Author
|
@nmdefries sorry for all the noise here; I tried to implement just 1 time utility from #494 but forgot it actually relied on the concept of a "unit" time delta/step; fixed that up and added the unit time step helper. Think that's fixed now. Also fixed some CHECK issues. The core changes, and now these helpers, should hopefully be ready now. |
nmdefries
reviewed
Nov 22, 2024
Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>
Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>
ec243a8 to
95b485f
Compare
95b485f to
081bd22
Compare
83a9618 to
b4bacf8
Compare
nmdefries
approved these changes
Nov 26, 2024
Contributor
nmdefries
left a comment
There was a problem hiding this comment.
Looks good. This is ready to merge aside from failing tests (looks like dplyr isn't loaded in examples).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
.suffix(and.prefix?) arguments to slides #542.)epi_slide_optwork with!!varname, maybe!!varnames, maybe!!!varnames#562.as_epi_df()#560.as_epi_dfshould ungroup input #573. (epipredict tests pass. epipredict bug identified, worked around, fix filed: cmu-delphi/epipredict#428)roll_iqr#575