Conversation
The pm_x and pm_y derivatives were accidentally in terms of days and not seconds. This commit changes the derivatives to be in terms of seconds.
Additionally, fix a couple of typos and a unit error in the t_ti derivative test.
Pchip interpolation ensures C1 continuity while avoiding global constraints such as in piecewise cubic spline interpolation. The Pchip routine added by this commit is now used by the BulletinData class. The added curvature did increase the error in some tests when compared to the basic finite difference calculation, so the test thresholds had to be increased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions to the primary transformation class which compute
Earth's angular velocity tensor. The tensor is computed primarily by
taking the partial derivative of the IAU 2006/2000A equations with
respect to time (in seconds).