Update dependencies, use Laminas Diactoros, ~update signature for Encoder::_doRequest and Decoder::_doRequest~#62
Update dependencies, use Laminas Diactoros, ~update signature for Encoder::_doRequest and Decoder::_doRequest~#62
Encoder::_doRequest and Decoder::_doRequest~#62Conversation
2c87600 to
1f64b79
Compare
1f64b79 to
77ab32b
Compare
Encoder::_doRequest and Decoder::_doRequestEncoder::_doRequest and Decoder::_doRequest~
c0da8c0 to
bb2b894
Compare
bb2b894 to
e1c778d
Compare
|
Thanks for this contribution! The updates you're proposing make sense in principle, but there are a few issues that make this difficult to review properly. The main problem is that this PR combines too many changes at once, and the tests aren't passing. When multiple changes are bundled together like this, it becomes very difficult to identify which specific change might be causing issues. Could you break this down into smaller, focused PRs? For example, one PR for dependency updates, another for switching to Laminas Diactoros, etc. This would make it much easier to review and test each change individually. Once the changes are separated and the tests are passing, we'd be happy to review each one properly. The functionality improvements look good, they just need to be presented in a more manageable way. Thanks for understanding! |
First, thank you so much for ReactPHP and ReactPHP-Soap! I am using both in a small project and bring a very nice improvement in performance.
I noticed that:
I went ahead and tried to address these observations:
Looking forward to your feedback!
EDIT: Since promises aims to support older PHP versions, I am dropping the
_doRequestsignature update to not break compatibility with PHP<8.0