Fixed bugs and updated LSM303 Library #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her 32bit processors. Fixed scope conflict causing a crashing bug when calling the breath() function.
Included new libraries that support 32bit processors and the LSM303. Verified working on ESP8266
cloudwalking
requested changes
Oct 11, 2017
hermes/hermes.ino
Outdated
| // Try to initialise and warn if we couldn't detect the chip | ||
| digitalWrite(ONBOARD_LED_PIN, HIGH); | ||
| if (!lsm.begin()) | ||
| { |
Owner
There was a problem hiding this comment.
put the curly on the same line -- matches the format of the rest of the project
hermes/hermes.ino
Outdated
| if (!lsm.begin()) | ||
| { | ||
| Serial.println("Oops ... unable to initialize the LSM303. Check your wiring!"); | ||
| while (1); |
Owner
There was a problem hiding this comment.
do you want to stop here forever? maybe just having the shoe light up red isn't so bad?
Author
There was a problem hiding this comment.
You are right. Makes more sense to go to red if the accel sensor is not working. However, at the moment only the RGB will show on the strip if this is the case. Red can be added in another branch.
|
I updated the code to use FastLED: https://github.com/climent/hermes-ng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed breathe() crashing bug.
Updated LSM303 Library to add support for 32bit processors.
Added hardware checking for LSM303