feat: add upstream reachability and pull-through services#44
Closed
DevonL wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces upstream reachability and pull-through services that enable dependency fetching via available upstreams in Cloudsmith. The implementation adds comprehensive capabilities for checking upstream availability and orchestrating dependency pulls through multiple package formats.
Changes:
- Adds
UpstreamPullServiceclass for orchestrating concurrent dependency pulls with authentication-aware redirect handling - Implements
upstreamGapAnalyzerfor enriching dependencies with upstream reachability information - Creates utility modules for registry endpoint management, package name normalization, and upstream format handling
- Refactors
UpstreamCheckerto expose upstream state queries for external consumption - Adds comprehensive test coverage for both services and their integration scenarios
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| util/upstreamPullService.js | Main service class that handles pull-through caching with concurrent request management, redirect validation, and authentication failure handling |
| util/upstreamGapAnalyzer.js | Analyzes uncovered dependencies across repositories to determine upstream reachability with progress reporting |
| util/registryEndpoints.js | Constructs registry trigger plans and validates registry URLs for 13+ package formats |
| util/packageNameNormalizer.js | Provides package name normalization and ecosystem-to-format mapping utilities |
| util/upstreamChecker.js | Refactored to export helper functions and add new method for querying active upstreams by format |
| test/upstreamPullService.test.js | Tests registry URL construction, mixed-ecosystem handling, redirect validation, and concurrency controls |
| test/upstreamGapAnalyzer.test.js | Tests dependency classification, upstream detection, and concurrency limiting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
10 tasks
d361d50 to
22ba0c3
Compare
22ba0c3 to
06e2e46
Compare
Collaborator
Author
|
Closing this PR because the initial split/stacking strategy was incorrect and produced oversized, overlapping diffs. A clean stacked PR set will be reopened from the original feature branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
Adds capabilities for dependency fetching via available upstreams
🔍 Related Issues
Link to any related GitHub issues (e.g.,
Fixes #12,Closes #34):🧪 Type of Change
Please check the relevant type tag for this PR title:
[FIX]Bug fix[NEW]New thing[REFACTOR]Internal changes such as code restructuring or optimization that does not alter functionality[DOC]Documentation-only changes[CHORE]Maintenance, cleanup, or CI configuration🧪 How Has This Been Tested?
Describe how you tested your changes. Include CI runs, local tests, manual verification, or screenshots if applicable.
📸 Screenshots (if applicable)
If UI or logs are affected, include before/after screenshots or output.
✅ Checklist