Skip to content

chore: remove legacy web app setting, all links now use app.cloudsmit…#28

Open
DevonL wants to merge 3 commits into
mainfrom
chore/remove-legacy-webapp
Open

chore: remove legacy web app setting, all links now use app.cloudsmit…#28
DevonL wants to merge 3 commits into
mainfrom
chore/remove-legacy-webapp

Conversation

@DevonL
Copy link
Copy Markdown
Collaborator

@DevonL DevonL commented Mar 27, 2026

…h.com

  • Remove useLegacyWebApp setting from package.json and README
  • Centralize web UI URL building in util/webAppUrls.js
  • Switch all browser-opening flows to app.cloudsmith.com unconditionally
  • Route remaining app links through shared helper in diagnosticsPublisher.js and installCommandBuilder.js
  • Add test coverage in webAppUrls.test.js

📄 Summary

Removes references to the legacy web app, and cleans up the original setting exposing it.

🔍 Related Issues

Link to any related GitHub issues (e.g., Fixes #12, Closes #34):

🧪 Type of Change

Please check the relevant type tag for this PR title:

  • [FIX] Bug fix
  • [NEW] New thing
  • [REFACTOR] Internal changes such as code restructuring or optimization that does not alter functionality
  • [DOC] Documentation-only changes
  • [CHORE] Maintenance, cleanup, or CI configuration

🧪 How Has This Been Tested?

Describe how you tested your changes. Include CI runs, local tests, manual verification, or screenshots if applicable.

📸 Screenshots (if applicable)

If UI or logs are affected, include before/after screenshots or output.

✅ Checklist

  • I’ve read and followed the CONTRIBUTING.md.
  • I’ve added or updated documentation as needed.
  • I’ve verified the change is tested and works as intended.
  • CI/CD checks pass and do not break existing functionality.
  • My code follows the style guidelines of this project.

…h.com

- Remove useLegacyWebApp setting from package.json and README
- Centralize web UI URL building in util/webAppUrls.js
- Switch all browser-opening flows to app.cloudsmith.com unconditionally
- Route remaining app links through shared helper in diagnosticsPublisher.js and installCommandBuilder.js
- Add test coverage in webAppUrls.test.js
@DevonL DevonL requested a review from colinmoynes as a code owner March 27, 2026 17:49
Copilot AI review requested due to automatic review settings March 27, 2026 17:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy web app setting and standardizes all UI links to the modern app.cloudsmith.com domain by centralizing URL construction in a shared helper.

Changes:

  • Removed the useLegacyWebApp setting and related documentation.
  • Introduced util/webAppUrls.js and routed multiple “open in Cloudsmith” flows through it.
  • Added unit tests for the new URL helper.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
views/quarantineExplainProvider.js Switches quarantine webview “View in Cloudsmith” action to use the shared package URL helper.
util/webAppUrls.js Adds centralized helpers for repository/package/package-group web URLs.
util/installCommandBuilder.js Uses shared repo URL builder (with base-url fallback) for unknown-format help text.
util/diagnosticsPublisher.js Routes vulnerability diagnostic links through the shared repo URL builder.
test/webAppUrls.test.js Adds unit coverage for the new URL helper functions.
package.json Removes the legacy web app setting contribution.
models/dependencyHealthNode.js Removes legacy self_webapp_url field from the dependency health node model.
extension.js Removes legacy URL branching and uses shared URL helpers for opening packages/groups.
README.md Removes the legacy web app setting from documented configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread util/webAppUrls.js
Comment thread util/webAppUrls.js Outdated
Comment thread util/diagnosticsPublisher.js Outdated
Comment thread util/webAppUrls.js
- Encode all dynamic path segments with encodeURIComponent in URL builders
- Replace manual query encoding with encodeURIComponent
- Set diagnostic.code to plain string when no URL is available
- Add copyright header to webAppUrls.js
Copy link
Copy Markdown
Contributor

@colinmoynes colinmoynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to hold off on this one for now, as we still have customers who utilise the old web app and do not use the newer one due to gaps. Once we officially move to deprecate the legacy web app, it will be good to remove this. So putting this on the back burner for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants