chore: remove legacy web app setting, all links now use app.cloudsmit…#28
Open
DevonL wants to merge 3 commits into
Open
chore: remove legacy web app setting, all links now use app.cloudsmit…#28DevonL wants to merge 3 commits into
DevonL wants to merge 3 commits into
Conversation
…h.com - Remove useLegacyWebApp setting from package.json and README - Centralize web UI URL building in util/webAppUrls.js - Switch all browser-opening flows to app.cloudsmith.com unconditionally - Route remaining app links through shared helper in diagnosticsPublisher.js and installCommandBuilder.js - Add test coverage in webAppUrls.test.js
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy web app setting and standardizes all UI links to the modern app.cloudsmith.com domain by centralizing URL construction in a shared helper.
Changes:
- Removed the
useLegacyWebAppsetting and related documentation. - Introduced
util/webAppUrls.jsand routed multiple “open in Cloudsmith” flows through it. - Added unit tests for the new URL helper.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| views/quarantineExplainProvider.js | Switches quarantine webview “View in Cloudsmith” action to use the shared package URL helper. |
| util/webAppUrls.js | Adds centralized helpers for repository/package/package-group web URLs. |
| util/installCommandBuilder.js | Uses shared repo URL builder (with base-url fallback) for unknown-format help text. |
| util/diagnosticsPublisher.js | Routes vulnerability diagnostic links through the shared repo URL builder. |
| test/webAppUrls.test.js | Adds unit coverage for the new URL helper functions. |
| package.json | Removes the legacy web app setting contribution. |
| models/dependencyHealthNode.js | Removes legacy self_webapp_url field from the dependency health node model. |
| extension.js | Removes legacy URL branching and uses shared URL helpers for opening packages/groups. |
| README.md | Removes the legacy web app setting from documented configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Encode all dynamic path segments with encodeURIComponent in URL builders - Replace manual query encoding with encodeURIComponent - Set diagnostic.code to plain string when no URL is available - Add copyright header to webAppUrls.js
colinmoynes
reviewed
Mar 30, 2026
Contributor
colinmoynes
left a comment
There was a problem hiding this comment.
I'm going to hold off on this one for now, as we still have customers who utilise the old web app and do not use the newer one due to gaps. Once we officially move to deprecate the legacy web app, it will be good to remove this. So putting this on the back burner for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h.com
📄 Summary
Removes references to the legacy web app, and cleans up the original setting exposing it.
🔍 Related Issues
Link to any related GitHub issues (e.g.,
Fixes #12,Closes #34):🧪 Type of Change
Please check the relevant type tag for this PR title:
[FIX]Bug fix[NEW]New thing[REFACTOR]Internal changes such as code restructuring or optimization that does not alter functionality[DOC]Documentation-only changes[CHORE]Maintenance, cleanup, or CI configuration🧪 How Has This Been Tested?
Describe how you tested your changes. Include CI runs, local tests, manual verification, or screenshots if applicable.
📸 Screenshots (if applicable)
If UI or logs are affected, include before/after screenshots or output.
✅ Checklist