chore(ENG-12048): v1 Deprecation notice#34
Closed
BartoszBlizniak wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
- Adds
@v1deprecation messaging across the action (runtime warning, action metadata, and docs) in response to Node.js 20 reaching EoL, and points users toward @v2/Node.js 24. - Updates package versioning and introduces a changelog entry for the deprecation notice.
Changes:
- Emit a runtime
core.warning(...)on every@v1invocation with migration guidance. - Add
@v1deprecation notice toREADME.md,action.yml, and newCHANGELOG.md. - Bump
package.json/package-lock.jsonversion to1.0.11and update the builtdist/index.js.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/main.js |
Adds a runtime deprecation warning with migration guidance. |
src/download-cli.js |
Tweaks fetch failure error message formatting. |
README.md |
Adds an @v1 deprecation callout and migration notes. |
action.yml |
Updates the marketplace/action description to include deprecation notice. |
CHANGELOG.md |
Adds a 1.0.11 entry documenting @v1 deprecation. |
package.json |
Bumps package version to 1.0.11. |
package-lock.json |
Keeps lockfile version metadata in sync with package.json. |
dist/index.js |
Updates compiled action output to match source changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const res = await fetch(url); | ||
| if (!res.ok) { | ||
| throw new Error(`Failed to fetch ${url}: ${res.statusText}`); | ||
| throw new Error(`Failed to fetch ${url} : ${res.statusText}`); |
| core.warning( | ||
| "cloudsmith-cli-action @v1 is DEPRECATED. v1 runs on Node.js 20, which reached end-of-life on 2026-04-30 (https://nodejs.org/en/about/previous-releases). " + | ||
| "Please migrate to @v2, which runs on Node.js 24. Security-only patches for v1 will continue until 2026-12-31. " + | ||
| "Migration guide: https://github.com/cloudsmith-io/cloudsmith-cli-action#readme", |
Comment on lines
+11
to
+17
| > **🛑 DEPRECATED — `@v1` is end-of-life.** | ||
| > | ||
| > `@v1` runs on Node.js 20, which reached [end-of-life on 2026-04-30](https://nodejs.org/en/about/previous-releases). Please migrate to [`@v2`](https://github.com/cloudsmith-io/cloudsmith-cli-action/tree/master#readme), which runs on Node.js 24. | ||
| > | ||
| > - **Migration guide:** see the [v2 README](https://github.com/cloudsmith-io/cloudsmith-cli-action/tree/master#readme) for breaking changes (Node.js 24 runtime, OIDC audience default). | ||
| > - **Security-only patches** for `@v1` will continue until **2026-12-31**. No new features or non-security fixes will land on `@v1` after that date. | ||
| > - To migrate, change `cloudsmith-io/cloudsmith-cli-action@v1` → `cloudsmith-io/cloudsmith-cli-action@v2` in your workflows. |
Comment on lines
+13
to
+15
| > `@v1` runs on Node.js 20, which reached [end-of-life on 2026-04-30](https://nodejs.org/en/about/previous-releases). Please migrate to [`@v2`](https://github.com/cloudsmith-io/cloudsmith-cli-action/tree/master#readme), which runs on Node.js 24. | ||
| > | ||
| > - **Migration guide:** see the [v2 README](https://github.com/cloudsmith-io/cloudsmith-cli-action/tree/master#readme) for breaking changes (Node.js 24 runtime, OIDC audience default). |
|
|
||
| ### Deprecated | ||
|
|
||
| - **`@v1` is deprecated.** v1 runs on Node.js 20, which reached [end-of-life on 2026-04-30](https://nodejs.org/en/about/previous-releases). Please migrate to [`@v2`](https://github.com/cloudsmith-io/cloudsmith-cli-action/tree/master#readme), which runs on Node.js 24. |
| @@ -1,5 +1,5 @@ | |||
| name: Cloudsmith CLI Setup | |||
| description: Set up Cloudsmith CLI in GitHub Actions | |||
| description: '[DEPRECATED — please migrate to @v2 (Node.js 24). v1 runs on Node.js 20 (EoL 2026-04-30); security-only patches until 2026-12-31.] Set up Cloudsmith CLI in GitHub Actions' | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the Node.js release cycle, Node 20 is now EoL — this change adds deprecation notices to
@v1. We will continue to provide security updates until end of 2026 to allow time for migration.Migrating from
@v1→@v21. Bump the action reference
2. OIDC audience default has changed
@v2now defaultsoidc-audiencetohttps://github.com/{org-name}(resolved fromGITHUB_REPOSITORY_OWNER) instead ofapi://AzureADTokenExchange.If your downstream validates the
audclaim against the old value, either update that validation or pinthe previous default explicitly:
3. Self-hosted runners need Node.js 24
GitHub-hosted runners are unaffected. Self-hosted runners must provide Node.js 24+.
No input or output names changed — existing workflows otherwise migrate one-for-one.