test: Improve screenshot test pages for select + multiselect #4179
Merged
test: Improve screenshot test pages for select + multiselect #4179
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4179 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 873 873
Lines 25653 25653
Branches 9284 9283 -1
=======================================
Hits 24921 24921
- Misses 685 726 +41
+ Partials 47 6 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
84eb935 to
e86348e
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves the screenshot test pages for select and multiselect components by adding padding to the screenshot area and introducing a toggle button to test virtual scroll functionality.
Changes:
- Added virtual scroll toggle button to both select and multiselect custom render option pages
- Added padding to screenshot areas for better visual testing
- Updated container styles to use
maxInlineSizeand addedblockSizefor better layout control
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pages/select/custom-render-option.page.tsx | Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions |
| pages/multiselect/custom-render-option.page.tsx | Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mxschll
reviewed
Jan 12, 2026
mxschll
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the dev pages in select + multiselect to have some padding for the screenshot tests as well as a virtual scroll button to toggle and test differences in virtual scroll and normal mode.
Related links, issue #, if available: n/a
How has this been tested?
Manual testing.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.