-
Notifications
You must be signed in to change notification settings - Fork 209
feat: Add public design tokens to slider #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dfd25f to
dcb0c9a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4178 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 873 873
Lines 25653 25653
Branches 9284 9284
=======================================
Hits 24921 24921
Misses 685 685
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pages/theming/slider.page.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's not really a need to add this page - let's skip it unless you have a strong reason to keep it, to keep our pages dir from growing too large
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It was helpful for me to do the tests and share how it works. I removed it.
5e6c77c to
dcb0c9a
Compare
dcb0c9a to
05e2d54
Compare
| colorBackgroundSegmentDisabled: '{colorBackgroundButtonNormalDisabled}', | ||
| colorBackgroundSegmentHover: '{colorBackgroundButtonNormalHover}', | ||
| colorBackgroundSegmentWrapper: '{colorBackgroundContainerContent}', | ||
| colorBackgroundSliderRangeDefault: { light: '{colorPrimary600}', dark: '{colorPrimary400}' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would probably make more sense to have the new Range tokens reference the Handle tokens rather than redefining the same values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, changed it to reference the handle tokens.
bc4f147 to
66084d2
Compare
Description
This PR makes the following design tokens public to resolve customer feature request for themeable Slider component:
Tested by running in the pipeline
Related links, issue #: AWSUI-61611
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.