Skip to content

Conversation

@amanabiy
Copy link
Member

@amanabiy amanabiy commented Jan 8, 2026

Description

This PR makes the following design tokens public to resolve customer feature request for themeable Slider component:

Tested by running in the pipeline

Related links, issue #: AWSUI-61611

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (69239f6) to head (61d13f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4178   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         873      873           
  Lines       25653    25653           
  Branches     9284     9284           
=======================================
  Hits        24921    24921           
  Misses        685      685           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy changed the title Slider design token feat: Slider design token Jan 8, 2026
@amanabiy amanabiy marked this pull request as ready for review January 9, 2026 08:09
@amanabiy amanabiy requested a review from a team as a code owner January 9, 2026 08:09
@amanabiy amanabiy requested review from gethinwebster and removed request for a team January 9, 2026 08:09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's not really a need to add this page - let's skip it unless you have a strong reason to keep it, to keep our pages dir from growing too large

Copy link
Member Author

@amanabiy amanabiy Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It was helpful for me to do the tests and share how it works. I removed it.

@amanabiy amanabiy force-pushed the slider-design-token branch from 5e6c77c to dcb0c9a Compare January 9, 2026 08:27
gethinwebster
gethinwebster previously approved these changes Jan 9, 2026
@amanabiy amanabiy force-pushed the slider-design-token branch from dcb0c9a to 05e2d54 Compare January 12, 2026 09:00
@amanabiy amanabiy changed the title feat: Slider design token feat: Adding public design tokens to slider Jan 12, 2026
@amanabiy amanabiy changed the title feat: Adding public design tokens to slider feat: Add public design tokens to slider Jan 12, 2026
colorBackgroundSegmentDisabled: '{colorBackgroundButtonNormalDisabled}',
colorBackgroundSegmentHover: '{colorBackgroundButtonNormalHover}',
colorBackgroundSegmentWrapper: '{colorBackgroundContainerContent}',
colorBackgroundSliderRangeDefault: { light: '{colorPrimary600}', dark: '{colorPrimary400}' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would probably make more sense to have the new Range tokens reference the Handle tokens rather than redefining the same values

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, changed it to reference the handle tokens.

@amanabiy amanabiy added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit bf484b5 Jan 13, 2026
50 checks passed
@amanabiy amanabiy deleted the slider-design-token branch January 13, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants