Skip to content

Conversation

@at-susie
Copy link
Member

@at-susie at-susie commented Jan 6, 2026

Description

Currently, when using size="inherit" on icons (e.g., external link icons), icons are sized based solely on line-height. This caused 16px font-size with 24px line-height to display medium size (20x20) icons instead of normal size (16x16) icons, making icons appear oversized relative to the text.

To address this, this PR adds an additional condition to display medium size icon when both line-height >= 24px AND font-size >= 20px.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (bf484b5) to head (541ac97).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4160   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         873      873           
  Lines       25653    25657    +4     
  Branches     9283     9283           
=======================================
+ Hits        24921    24925    +4     
  Misses        726      726           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Georgii Lobko <47106899+georgylobko@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
Co-authored-by: Georgii Lobko <47106899+georgylobko@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@at-susie at-susie enabled auto-merge January 13, 2026 09:27
@at-susie at-susie added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 2d209a1 Jan 13, 2026
84 of 85 checks passed
@at-susie at-susie deleted the feat/small-icon branch January 13, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants