Skip to content

feat: Support int32 to uint64 in reverseTransformArray #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Mar 23, 2026
Merged

feat: Support int32 to uint64 in reverseTransformArray #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b8ed37
feat(parquet): Support int32 to uint64 in reverseTransformArray
erezrokah Mar 23, 2026
cc2970a
fix(parquet): Panic on negative int32 values when converting to uint64
erezrokah Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions parquet/read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ func reverseTransformArray(dt arrow.DataType, arr arrow.Array) arrow.Array {
return reverseTransformTime64(dt.(*arrow.Time64Type), arr)
case *array.Date32:
return reverseTransformFromDate32(dt, arr)
case *array.Int32:
return reverseTransformFromInt32(dt, arr)
case *array.Uint32:
return reverseTransformFromUint32(dt, arr)
case *array.Struct:
Expand Down Expand Up @@ -102,6 +104,27 @@ func reverseTransformArray(dt arrow.DataType, arr arrow.Array) arrow.Array {
}
}

func reverseTransformFromInt32(dt arrow.DataType, arr *array.Int32) arrow.Array {
switch dt {
case arrow.PrimitiveTypes.Uint64:
builder := array.NewUint64Builder(memory.DefaultAllocator)
for i := 0; i < arr.Len(); i++ {
if arr.IsNull(i) {
builder.AppendNull()
continue
}
v := arr.Value(i)
if v < 0 {
panic(fmt.Errorf("negative int32 value %d at index %d cannot be converted to uint64", v, i))
Comment on lines +110 to +118
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverseTransformFromInt32 allocates a Uint64Builder but never releases it. In Arrow Go, builders are reference-counted and should be Release()d to avoid leaking allocator-backed memory; you can defer builder.Release() (safe because builder.NewArray() returns a separate array) or release after creating the array.

Copilot uses AI. Check for mistakes.
}
builder.Append(uint64(v))
}
return builder.NewArray()
default:
panic(fmt.Errorf("unsupported conversion from %s to %s", arr.DataType(), dt))
}
}

func reverseTransformFromUint32(dt arrow.DataType, arr *array.Uint32) arrow.Array {
switch dt {
case arrow.PrimitiveTypes.Uint64:
Expand Down
95 changes: 95 additions & 0 deletions parquet/read_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,98 @@ func TestReverseTransformArray_Uint32ToUint64_ListOf(t *testing.T) {
require.Equal(t, uint64(2), values.Value(1))
require.Equal(t, uint64(3), values.Value(2))
}

func TestReverseTransformArray_Int32ToUint64(t *testing.T) {
builder := array.NewInt32Builder(memory.DefaultAllocator)
defer builder.Release()

builder.Append(0)
builder.Append(42)
builder.AppendNull()
builder.Append(2147483647) // max int32

arr := builder.NewArray()
defer arr.Release()

result := reverseTransformArray(arrow.PrimitiveTypes.Uint64, arr)
defer result.Release()

require.Equal(t, arrow.PrimitiveTypes.Uint64, result.DataType())
require.Equal(t, 4, result.Len())

u64 := result.(*array.Uint64)
require.Equal(t, uint64(0), u64.Value(0))
require.False(t, u64.IsNull(0))

require.Equal(t, uint64(42), u64.Value(1))
require.False(t, u64.IsNull(1))

require.True(t, u64.IsNull(2))

require.Equal(t, uint64(2147483647), u64.Value(3))
require.False(t, u64.IsNull(3))
}

func TestReverseTransformArray_Int32ToUint64_Empty(t *testing.T) {
builder := array.NewInt32Builder(memory.DefaultAllocator)
defer builder.Release()

arr := builder.NewArray()
defer arr.Release()

result := reverseTransformArray(arrow.PrimitiveTypes.Uint64, arr)
defer result.Release()

require.Equal(t, arrow.PrimitiveTypes.Uint64, result.DataType())
require.Equal(t, 0, result.Len())
}

func TestReverseTransformArray_Int32ToUint64_ListOf(t *testing.T) {
bldr := array.NewListBuilder(memory.DefaultAllocator, arrow.PrimitiveTypes.Int32)
defer bldr.Release()

vb := bldr.ValueBuilder().(*array.Int32Builder)

bldr.Append(true)
vb.Append(1)
vb.Append(2)

bldr.Append(true)
vb.Append(3)

bldr.AppendNull()

arr := bldr.NewArray()
defer arr.Release()

targetDt := arrow.ListOf(arrow.PrimitiveTypes.Uint64)
result := reverseTransformArray(targetDt, arr)
defer result.Release()

require.True(t, arrow.TypeEqual(targetDt, result.DataType()))
require.Equal(t, 3, result.Len())

listArr := result.(*array.List)
require.False(t, listArr.IsNull(0))
require.False(t, listArr.IsNull(1))
require.True(t, listArr.IsNull(2))

values := listArr.ListValues().(*array.Uint64)
require.Equal(t, uint64(1), values.Value(0))
require.Equal(t, uint64(2), values.Value(1))
require.Equal(t, uint64(3), values.Value(2))
}

func TestReverseTransformArray_Int32ToUint64_NegativePanics(t *testing.T) {
builder := array.NewInt32Builder(memory.DefaultAllocator)
defer builder.Release()

builder.Append(-1)

arr := builder.NewArray()
defer arr.Release()

require.PanicsWithError(t, "negative int32 value -1 at index 0 cannot be converted to uint64", func() {
reverseTransformArray(arrow.PrimitiveTypes.Uint64, arr)
})
}
Loading