Conversation
|
You have changed all the indentation from tabs to spaces, which is not OK: in addition to being against the project's original code style, it makes it really hard to review the changes as there are huge blocks that show up as being replaced even though there is likely no change other than tabs and spaces. I understand that Vert.x internal coding style is to use spaces, but I think they are wrong and I do not feel that its a requirement for all Vert.x related 3rd party projects to use the same indentation style. If you can update the MR without the unwanted indentation changes, I would appreciate it as it will let me review the changes properly. |
|
I have refined as I can. |
|
There are still a lot of white space changes with no obvious need. Please avoid changing the style of the project.
Before committing, please verify that there are no unneeded changes - a change in whitespace when there's no code change on the same line, is unneeded. Please don't try to fix the code style of the entire file when changing code. Lets focus on the code changes. I also have a content note: You have imported |
No logic changed; only changed style from vert.x 4 to vert.x 5.