-
Notifications
You must be signed in to change notification settings - Fork 28
Blog: add interview with Matthew Mols/pgEdge #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Floor Drees <floordrees@gmail.com>
jsilvela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of typos, several suggestions.
On the column width thing (I did see you mention it, yes): for the code review, making a correction makes one modify a whole paragraph, rather than a single line.
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
mmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FloorD This looks great - thank you for putting it together.
My only ask is to remove the exclamations at the end of the quotes (three instances) - the tone is a bit off with them.
@mmols would love to hear what you think.
Team, I know I need to adjust column width still.