Skip to content

Conversation

@FloorD
Copy link
Contributor

@FloorD FloorD commented Dec 16, 2025

@mmols would love to hear what you think.
Team, I know I need to adjust column width still.

Signed-off-by: Floor Drees <floordrees@gmail.com>
@FloorD FloorD requested a review from a team as a code owner December 16, 2025 13:48
Copy link
Contributor

@jsilvela jsilvela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of typos, several suggestions.
On the column width thing (I did see you mention it, yes): for the code review, making a correction makes one modify a whole paragraph, rather than a single line.

FloorD and others added 6 commits December 17, 2025 11:38
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Copy link
Contributor

@mmols mmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FloorD This looks great - thank you for putting it together.

My only ask is to remove the exclamations at the end of the quotes (three instances) - the tone is a bit off with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants