feat: support overriding test image#729
Open
vincent-onebrief wants to merge 2 commits intocloudnative-pg:mainfrom
Open
feat: support overriding test image#729vincent-onebrief wants to merge 2 commits intocloudnative-pg:mainfrom
vincent-onebrief wants to merge 2 commits intocloudnative-pg:mainfrom
Conversation
dosubot
Bot
added
the
size:M
Signed-off-by: vincent-onebrief <vincent@onebrief.com>
vincent-onebrief
force-pushed
the
vincent/override-test-image-700
branch
from
0ec0370 to
c4037c8
Compare
Signed-off-by: vincent-onebrief <vincent@onebrief.com>
|
Hey @itay-grudev 👋🏻 would it be possible to have this PR reviewed? It'd be nice to get control over which image to use for this Job and not rely on this older Alpine image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test resource is currently hard-coded to a specific alpine image. This image is old and contains vulnerabilities.
Users should be able to override this image when required.
I did not change the image as that may be considered a breaking change
Related Issue
Related: #700
Checklist before merging