projects: warn via stderr instead of log.Printf on pane-label failure#37
Merged
Conversation
Follow-up to #33. The pane-label failure warning used log.Printf, which stamps a timestamp prefix and pulled in the log package solely for this one line — unlike the rest of the plugin, which emits messages via fmt to stdout/stderr with a "herdr-plus:" prefix (captured in the plugin log). Match that convention and drop the now-unused log import. Behavior is unchanged: labeling stays best-effort and a failure never aborts building the workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #33 (thanks again @javimb!).
The pane-label failure warning added in #33 used
log.Printf:That stamps a
log-package timestamp prefix and pulls in thelogpackage solely for this one line — inconsistent with the rest of the plugin, which emits messages viafmtto stdout/stderr with aherdr-plus:prefix (what herdr captures in the plugin log). This switches it to match:and drops the now-unused
logimport.Behavior is unchanged — labeling stays best-effort and a failure never aborts building the workspace.
go build,go test, andgo vetall pass.