Skip to content

Harden dockerfile update base images #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anthony-Ucci wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Harden dockerfile update base images #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b857528
Harden Dockerfile and update base images
Jun 15, 2026
a6a3892
Harden Dockerfile and update base images
Jun 15, 2026
c91a2a0
Merge branch 'harden-dockerfile-update-base-images' of https://github…
Jun 15, 2026
95ee67b
disable list all buckets by defaut
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,37 @@
FROM docker.io/golang:1 AS builder
FROM docker.io/library/golang:1.26.4-alpine AS builder

WORKDIR /usr/src/app

COPY go.mod go.sum ./
RUN go mod download

COPY . ./
RUN CGO_ENABLED=0 go build -ldflags="-s -w" -a -installsuffix cgo -o bin/s3manager

FROM docker.io/alpine:latest
RUN CGO_ENABLED=0 go build \
-ldflags="-s -w" \
-a \
-installsuffix cgo \
-o bin/s3manager

FROM docker.io/library/alpine:3.23

WORKDIR /usr/src/app
RUN addgroup -S s3manager && adduser -S s3manager -G s3manager
RUN apk add --no-cache \
ca-certificates \
dumb-init

RUN apk update \
&& apk upgrade --no-cache \
&& apk add --no-cache \
ca-certificates \
dumb-init \
&& addgroup -S s3manager \
&& adduser -S s3manager -G s3manager \
&& rm -rf /var/cache/apk/*

COPY --from=builder --chown=s3manager:s3manager /usr/src/app/bin/s3manager ./

USER s3manager

EXPOSE 8080
ENTRYPOINT [ "/usr/bin/dumb-init", "--" ]
CMD [ "/usr/src/app/s3manager" ]

ENTRYPOINT ["/usr/bin/dumb-init", "--"]

CMD ["/usr/src/app/s3manager"]
5 changes: 5 additions & 0 deletions internal/app/s3manager/manager_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ func HandleBucketsViewWithManager(manager *MultiS3Manager, templates fs.FS, allo
return
}

if bucketName != "" {
http.Redirect(w, r, rootURL+"/"+instanceName+"/buckets/"+bucketName, http.StatusTemporaryRedirect)
return
}

s3 := current.Client
instances := manager.GetAllInstances()

Expand Down
12 changes: 8 additions & 4 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,17 @@ func main() {
// Set up router
r := mux.NewRouter()

// Root redirects to first instance's buckets page
// Root redirects to first instance's buckets page (or directly to the configured bucket)
r.Handle("/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
instances := s3Manager.GetAllInstances()
if len(instances) > 0 {
http.Redirect(w, r, rootURL+"/"+instances[0].Name+"/buckets", http.StatusPermanentRedirect)
} else {
if len(instances) == 0 {
http.Error(w, "No S3 instances configured", http.StatusInternalServerError)
return
}
if configuration.BucketName != "" {
http.Redirect(w, r, rootURL+"/"+instances[0].Name+"/buckets/"+configuration.BucketName, http.StatusPermanentRedirect)
} else {
http.Redirect(w, r, rootURL+"/"+instances[0].Name+"/buckets", http.StatusPermanentRedirect)
}
})).Methods(http.MethodGet)

Expand Down