-
Notifications
You must be signed in to change notification settings - Fork 31
Implement Image and Text Overlays #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aatanasov-cloudinary
wants to merge
26
commits into
develop
Choose a base branch
from
feature/overlays
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns are enabled by default
gabrielcld2
reviewed
Dec 18, 2025
Collaborator
gabrielcld2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things I've noticed, otherwise the code looks really good 👍
gabrielcld2
approved these changes
Dec 23, 2025
Collaborator
gabrielcld2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected 🎉 great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked and enhanced the Transformations attachment page.
Approach
settings-pages.phpapproach for adding the additional elements to the asset edit page.text_overlayandimage_overlaycolumns to the dbwp_cloudinary_relationshipstable. There are two main reasons behind that decision:transformation-- this is actually used on the front-end, which is built through the other JSON data.QA notes
During testing, consider image and video types.
This PR includes a DB upgrade, which happens on plugin install and checks the current and the previous Cloudinary versions.
wp_cloudinary_relationshipstable you should have thetext_overlayandimage_overlaycolumns:When those tables are available, go to the Media Library and add effects to an asset using that column:
By default, those icons should be empty in the Media Library.
Try different variations using the edit panels and ensure the preview works. If an invalid transformation is added to the free text, an alert will appear.
When using different effects, they should be reflected here:
Test the Clear buttons and ensure they remove the added text/image.
When saved effects, this message should appear for a few seconds.
When we apply effects, the relevant icons should be highlighted (example):
Test the front-end with assets that have effects and ensure the effects appear.
Update assets with new effects and ensure they are reflected on the front-end.
Test if all transformations appear in the Rest API as well. Example:
wp-json/wp/v2/media/4176Test the front-end with/without lazy-load enabled.
Ensure the Cloudinary Status shows all effects and the Edit Effects text link: