fix(composer): allow single pipe for backward compatibility in PHP version selection#1217
Open
dcmbrs wants to merge 1 commit intocloudfoundry:masterfrom
Open
fix(composer): allow single pipe for backward compatibility in PHP version selection#1217dcmbrs wants to merge 1 commit intocloudfoundry:masterfrom
dcmbrs wants to merge 1 commit intocloudfoundry:masterfrom
Conversation
|
|
ramonskie
approved these changes
Jan 29, 2026
Contributor
ramonskie
left a comment
ramonskie
left a comment
There was a problem hiding this comment.
looks good to me. thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the Composer constraint parser to correctly handle version constraints using a single pipe (|) as a logical OR.
The tool now treats | and || equivalently, aligning its behavior with Composer’s semver implementation and ensuring backward compatibility.
Composer doc : https://getcomposer.org/doc/articles/versions.md
Composer regex "OR" : https://github.com/composer/semver/blob/main/src/VersionParser.php#L278
Several existing Composer projects define PHP version constraints using a single pipe operator (e.g. ^7.1 | ^8.0), which is valid and supported by Composer.
Previously, such configurations were not correctly interpreted by the tool, leading to incorrect PHP version selection or failures.
This change ensures that projects relying on this syntax are handled correctly without requiring configuration changes.