remove idle suffix from bg deploy #1697
Conversation
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Outdated
Show resolved
Hide resolved
...-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ScaleAppStep.java
Outdated
Show resolved
Hide resolved
ikasarov
force-pushed
the
remove-idle-new
branch
from
9749112 to
b9b7baa
Compare
| .shouldKeepExistingEnv() ? UpdateStrategy.MERGE : UpdateStrategy.REPLACE; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Instead of creating a new method and flow, can you create a new ApplicationAttributeUpdater. For example, ApplicationNameApplicationAttributeUpdater and update the application name in handleApplicationAttributes (Update flow)?
There was a problem hiding this comment.
Decided on in-between solution - removing the new method but not implementing an ApplicationAttributeUpdater for a specific reason - the attribute updaters are used in a stream but are all dependant on the application name which the new updater would be changing. This makes the order of the attributeUpdaters very important and would be easy to break in the future.
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Show resolved
Hide resolved
...ava/org/cloudfoundry/multiapps/controller/process/steps/RemoveNewApplicationsSuffixStep.java
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Show resolved
Hide resolved
| public void handleApplicationName() { | ||
| } |
There was a problem hiding this comment.
If you agree with my other comment this method will not be needed. If you do not, add some comment why there is no implementation here
...src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateAppStep.java
Show resolved
Hide resolved
.../test/java/org/cloudfoundry/multiapps/controller/core/cf/detect/AppSuffixDeterminerTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/cloudfoundry/multiapps/controller/process/util/ArchiveEntryExtractorTest.java
Show resolved
Hide resolved
...in/java/org/cloudfoundry/multiapps/controller/web/resources/ApplicationShutdownResource.java
Show resolved
Hide resolved
...g/cloudfoundry/multiapps/controller/process/steps/CreateOrUpdateStepWithExistingAppTest.java
Show resolved
Hide resolved
| return expectedEnvMap; | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
this is the straight scenario, how about adding other scenarios, where renaming should not be applied or other?
ikasarov
force-pushed
the
remove-idle-new
branch
from
3b384a8 to
2fe0804
Compare
3 participants
during blue-green deployment, move the idle application renaming before the restage (in CreateOrUpdateAppStep) - ensuring the new name is applied before the restart/restage
fix ArchiveEntryExtractorTest incorrect handling of newline leading to windows errors
See: LMCROSSITXSADEPLOY-2755