Fix angular integration test staging timeout#1250
Open
tnikolova82 wants to merge 1 commit into
Open
Conversation
The angular integration test was timing out (>15 min) during staging because the fixture had a bloated dependency tree (~939 npm packages including bootstrap, jquery, oidc-client, karma, etc.). Strip the fixture to the minimum needed: core Angular packages only, single component, no routing/http/forms. This reduces npm install + ng build time significantly while preserving the test assertion (<title>source_app</title>). - Remove unused deps: bootstrap, jquery, oidc-client, popper, karma, etc. - Remove unused components: counter, fetch-data, home, nav-menu - Remove SpaProxy NuGet package - Add @types/node override for TypeScript 4.6 compatibility - Add skipLibCheck to tsconfig - Simplify Program.cs to static file server only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
angular_dotnetfixture to the minimum needed to pass the integration test, fixing staging timeouts (>15 min)@types/nodeversion override andskipLibCheckfor TypeScript 4.6 compatibilityProblem
The "deploying an angular app" integration test (
node_test.go) was timing out during staging becausenpm install+ng build --prodof the bloated Angular 13 fixture exceeded the 15-minute CF staging timeout. The fixture included unnecessary dependencies and components that aren't needed for the test assertion (<title>source_app</title>).Verification
Build tested locally —
ng build --configuration productioncompletes in ~18 seconds with the simplified fixture.