Fix shutdown of periodic_updater #4711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* current implementation produces "error: can't be called from trap"
jochenehret
force-pushed
the
fix_periodic_updater_shutdown
branch
from
cad5e79 to
ddb5f75
Compare
philippthun
reviewed
Dec 19, 2025
* avoids use of sleep commands
philippthun
approved these changes
Dec 19, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Dec 19, 2025
Changes in cloud_controller_ng:
- Fix shutdown of periodic_updater
PR: cloudfoundry/cloud_controller_ng#4711
Author: Jochen Ehret <jochen.ehret@sap.com>
Dependency updates in cloud_controller_ng:
- build(deps): bump sequel_pg from 1.18.1 to 1.18.2
PR: cloudfoundry/cloud_controller_ng#4716
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps-dev): bump webrick from 1.9.1 to 1.9.2
PR: cloudfoundry/cloud_controller_ng#4715
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Current shutdown function produces "error: can't be called from trap". Deferring the shutdown to an at_exit hook so that it runs after the trap handler avoids the error. Tested manually with
bosh stop api/bosh start api(error was logged in cloud_controller.log file).An explanation of the use cases your change solves
Enable clean shutdown of PeriodicUpdater when Puma shuts down
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests