Fix config compatibility after dependency bumps#65
Open
svkrieger wants to merge 1 commit into
Open
Conversation
svkrieger
commented
Jun 11, 2026
svkrieger
commented
Contributor
- Implement GetAdminOrigin and GetUserOrigin required by cf-test-helpers v2.13.0
- Interpret basic_timeout and long_timeout in config.yml as seconds; viper v1.21.0 changed time.Duration parsing to treat plain integers as nanoseconds, which broke existing user configs
- Move timeout defaults from NewConfig to viper.SetDefault so the new seconds multiplication applies uniformly
|
|
- Implement GetAdminOrigin and GetUserOrigin required by cf-test-helpers v2.13.0 - Interpret basic_timeout and long_timeout in config.yml as seconds; viper v1.21.0 changed time.Duration parsing to treat plain integers as nanoseconds, which broke existing user configs - Move timeout defaults from NewConfig to viper.SetDefault so the new seconds multiplication applies uniformly
svkrieger
force-pushed
the
fix-config-after-dependency-bumps
branch
from
3a78ae4 to
de44701
Compare
jochenehret
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.