Storage CLI Client #595
Merged
Storage CLI Client #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- templates updated to be compatible with storage-cli. - All providers supported by storage-cli added into templates - package for storage-cli created - blob storage-cli dev version added to be tested
- Since these json's also consumed by storage-cli and this custom field not exist at storage-cli config struct. Even though go lang did not complain about extra fields, we should not add.
5 tasks
3 tasks
- storage-cli/storage-cli-0.0.1-linux-amd64 uploaded into capi-release-blobs bucket
kathap
reviewed
Dec 22, 2025
jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb
Outdated
Show resolved
Hide resolved
kathap
reviewed
Dec 22, 2025
jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb
Outdated
Show resolved
Hide resolved
kathap
reviewed
Dec 22, 2025
| ca_cert=l.p("#{scope}.ca_cert",nil) | ||
| unless ca_cert.empty? | ||
| options["tls"]={"cert"=>ca_cert} | ||
| end |
Contributor
There was a problem hiding this comment.
Should we stick to the naming like in cf-deployment.yml for webdav?
ca_cert:
blobstore_timeout:
password:
private_endpoint:
public_endpoint:
username:
Contributor
Author
There was a problem hiding this comment.
for the webdav provider, we can discus(arrive at a conclusion) later on otherwise we have to do some changes in this config file which requires discussion with bosh team.
kathap
reviewed
Dec 22, 2025
jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb
Outdated
Show resolved
Hide resolved
kathap
reviewed
Dec 22, 2025
kathap
reviewed
Dec 23, 2025
kathap
reviewed
Dec 23, 2025
kathap
reviewed
Dec 23, 2025
kathap
reviewed
Dec 23, 2025
kathap
reviewed
Dec 23, 2025
jochenehret
requested changes
Dec 30, 2025
Contributor
jochenehret
left a comment
jochenehret
left a comment
There was a problem hiding this comment.
Looks good, no regressions found. Just some docu updates are missing.
jochenehret
previously approved these changes
Jan 2, 2026
kathap
previously approved these changes
Jan 7, 2026
kathap
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR prepares the codebase for replacing the Fog library. Azure support through Fog will be removed in the future, so we need to start migrating away from it step by step.
Solution
A Go-based storage-cli client is being developed in this repository: https://github.com/cloudfoundry/storage-cli/
The project is still under development, and missing features are being added gradually. This client needs config json to run. With this PR we added .erb files to generate config files during deployment.
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite