Skip to content

CI: add windows testing and linting to Go workflow #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ctlong wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −20
Draft

CI: add windows testing and linting to Go workflow #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0b9a6b
CI: run Go workflow on windows as well
ctlong Oct 18, 2022
de3eaad
CI: run go workflow on a weekly schedule
ctlong Oct 18, 2022
d9bc505
Fix integration tests for windows
ctlong Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,44 @@ on:
pull_request:
branches:
- main
schedule:
- cron: '40 1 * * 2'

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- run: go run github.com/onsi/ginkgo/v2/ginkgo -r --procs=3 --compilers=3 --randomize-all --randomize-suites --fail-on-pending --keep-going --race --trace
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- run: go run github.com/onsi/ginkgo/v2/ginkgo -r --procs=3 --compilers=3 --randomize-all --randomize-suites --fail-on-pending --keep-going --race --trace

vet:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- run: go vet ./...
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- run: go vet ./...

lint:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- uses: golangci/golangci-lint-action@v3.2.0
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
- uses: golangci/golangci-lint-action@v3.2.0
with:
args: --timeout 5m
4 changes: 2 additions & 2 deletions integration/syslog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ var _ = Describe("Blackbox", func() {

var message *sl.Message
Eventually(inbox.Messages, "5s").Should(Receive(&message))
Expect(message.Content).To(ContainSubstring(tagName + "/" + logfileName))
Expect(message.Content).To(MatchRegexp(tagName + `[/\\]` + logfileName))

blackboxRunner.Stop()
})
Expand Down Expand Up @@ -249,7 +249,7 @@ var _ = Describe("Blackbox", func() {
blackboxRunner.Stop()
})
It("removes all characters that are not between ASCII 33 - 126 from the tag name", func() {
specialCharsName := "ab c§d "
specialCharsName := "ab c§d"
expectedNoSpecialCharsName := "abcd"

err := os.Mkdir(filepath.Join(logDir, specialCharsName), os.ModePerm)
Expand Down