[vitest-pool-workers] STOR-5343: Add Durable Object eviction helpers#14398
Conversation
🦋 Changeset detectedLatest commit: 8c04e9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
The analysis is complete. Let me assess the actionable issues: The key observations:
Let me double-check the test for the bulk eviction — after None of these rise to the level of a clear logic bug, security issue, or backward-compatibility violation. The same-isolate concern is genuinely uncertain (eviction semantics differ from LGTM |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jtolio
left a comment
There was a problem hiding this comment.
How much of the TypeScript definitions come from the Workerd automated output?
None 😅 I will try tomorrow, as I had no idea that existed! |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
@james-elicx this is waiting on a workerd bump before it can be merged, but be helpful to get a pass at the code before then |
3297fcb to
392560d
Compare
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
3f3bca5 to
7b1044f
Compare
a238d7f to
8c04e9a
Compare
Adds two new helpers to
vitest-pool-workersthat enable the testing of evictions for Durable Objects. It adds two new helpers:evictDurableObject(stub)just evicts a single DOevictAllDurableObjectsevicts all DOs