Make remote dev exchange_url optional#12771
Conversation
🦋 Changeset detectedLatest commit: f696f57 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
✅ All changesets look good |
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Incomplete tailLogs removal enables inspector proxy in remote mode without an inspector URL (packages/wrangler/src/api/startDevWorker/ProxyController.ts:414-418)
The PR removed the --experimental-tail-logs CLI flag (which had default: true), and stopped setting input.experimental.tailLogs in start-dev.ts. However, the check at ProxyController.ts:417 still gates inspector behavior on !this.latestConfig?.experimental?.tailLogs. Since tailLogs is now always false (because ConfigController.ts:375 computes !!input.experimental?.tailLogs from the now-absent input), the inspectorEnabled getter returns true for remote mode — the opposite of the previous default behavior.
Before this PR: tailLogs defaulted to true → !true = false → inspector disabled in remote mode.
After this PR: tailLogs is always false → !false = true → inspector enabled in remote mode.
But the PR also removed userWorkerInspectorUrl from the proxyData emitted by RemoteRuntimeController (RemoteRuntimeController.ts:307). So the InspectorProxyWorker is now started (ProxyController.ts:139) and receives reloadComplete messages (ProxyController.ts:457-461) with no inspector URL to connect to, which is a regression from the previous default behavior.
View 6 additional findings in Devin Review.
…workers - Fix test mocks to match new CfPreviewSession/CfPreviewToken shapes - playground-preview-worker: make exchange_url optional, use initial token as fallback, remove inspector URL construction and prewarm - playground frontend: remove inspector from response codec - edge-preview-authenticated-proxy: remove /exchange CORS proxy endpoint (dead since DEVX-979), remove prewarm from .update-preview-token flow
c2f5da8 to
dbe6908
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM with a few nits.
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Depending on the zone settings, a fetch to
exchange_urlcan sometimes fail. This PR makes that fetch optional, falling back to the raw token provided by the control plane. Additionally, it removes the experimental tail logs flag, which is now always on.A picture of a cute animal (not mandatory, but encouraged)