Skip to content

Add cross-process support to local explorer#12754

Merged
emily-shen merged 12 commits intomainfrom
emily/debug-build-break
Mar 9, 2026
Merged

Add cross-process support to local explorer#12754
emily-shen merged 12 commits intomainfrom
emily/debug-build-break

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Mar 4, 2026

Would recommend reviewing by commit!

This lets you view all resources that are bound to any running worker, even if in a different miniflare process

  • uses the dev registry to detect any other running process, regardless of whether there are service bindings between processes
  • Supporting pagination while aggregating across resources gets really messy, so I've decided to drop pagination for listing resources. This seems fine because its unlikely someone's going to have enough bindings to make pagination needed.

404 responses now have accurate error codes (based on the actual CF API)

TODO (in a followup): show in the UI which workers are running, and what persistence directory the resource is using

See below for how aggregated listing works:

image

For operations on specific resources, (e.g. KV key put), we look for the namespace locally first then search others.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: wip experimental thing

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@emily-shen emily-shen requested a review from a team as a code owner March 4, 2026 13:49
@emily-shen emily-shen marked this pull request as draft March 4, 2026 13:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 4, 2026

🦋 Changeset detected

Latest commit: 8da11f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 4, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Comment thread packages/local-explorer-ui/src/drivers/d1.ts
devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 4, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12754

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12754

miniflare

npm i https://pkg.pr.new/miniflare@12754

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12754

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12754

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12754

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12754

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12754

wrangler

npm i https://pkg.pr.new/wrangler@12754

commit: 0aa7ce6

@emily-shen emily-shen force-pushed the emily/debug-build-break branch 2 times, most recently from 8b89fe9 to c9d187a Compare March 4, 2026 16:37
@emily-shen emily-shen marked this pull request as ready for review March 4, 2026 16:38
devin-ai-integration[bot]

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

✅ All changesets look good

devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread fixtures/worker-with-resources/worker-b/index.ts Outdated
Comment thread fixtures/worker-with-resources/package.json
Comment thread packages/miniflare/src/plugins/core/explorer.ts
Comment thread packages/miniflare/src/shared/dev-registry.ts Outdated
Comment thread packages/miniflare/src/shared/dev-registry.ts
Comment thread packages/miniflare/src/workers/local-explorer/resources/kv.ts Outdated
Comment thread packages/miniflare/src/workers/local-explorer/aggregation.ts
Comment thread packages/miniflare/src/workers/local-explorer/aggregation.ts Outdated
Comment thread packages/miniflare/src/workers/local-explorer/resources/do.ts Outdated
Comment thread packages/miniflare/test/plugins/local-explorer/aggregation.spec.ts Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I left a bunch of comments but none blocking. I think Devin still has a few outstanding issues to address though.

Comment thread packages/miniflare/scripts/filter-openapi.ts Outdated
Comment thread packages/miniflare/scripts/filter-openapi.ts
Comment thread packages/miniflare/scripts/filter-openapi.ts
Comment thread packages/miniflare/src/workers/local-explorer/explorer.worker.ts
Comment thread packages/miniflare/test/plugins/local-explorer/aggregation.spec.ts Outdated
Comment thread packages/miniflare/test/plugins/local-explorer/aggregation.spec.ts Outdated
Comment thread packages/miniflare/test/plugins/local-explorer/aggregation.spec.ts
Comment thread packages/miniflare/src/workers/local-explorer/aggregation.ts
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 6, 2026
@emily-shen emily-shen force-pushed the emily/debug-build-break branch from ec67e7b to d189f16 Compare March 9, 2026 15:18
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@emily-shen emily-shen force-pushed the emily/debug-build-break branch from d189f16 to 8da11f7 Compare March 9, 2026 15:26
@emily-shen emily-shen merged commit e4d9510 into main Mar 9, 2026
38 checks passed
@emily-shen emily-shen deleted the emily/debug-build-break branch March 9, 2026 16:14
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants