[wrangler] serialize custom build watch events to avoid concurrent runs by dhruv7539 · Pull Request #12704 · cloudflare/workers-sdk

dhruv7539 · 2026-02-27T18:45:07Z

Summary

serialize custom build watch-triggered runs in BundlerController
keep only the latest pending file-change build request when many events arrive in a burst
preserve stale-build suppression by retaining the existing abort-controller checks

Why

Fixes the behavior in #10944 where rapid multi-file changes can start multiple custom builds at once.

Testing

pnpm -C packages/wrangler test src/__tests__/api/startDevWorker/BundleController.test.ts
pnpm -C packages/wrangler exec eslint src/api/startDevWorker/BundlerController.ts src/__tests__/api/startDevWorker/BundleController.test.ts

Added regression test

custom build watcher changes are processed without concurrent custom builds
uses a lock file in a test custom-build script to fail if two builds overlap
updates multiple watched files in quick succession and verifies no Custom build failed events are emitted

changeset-bot · 2026-02-27T18:45:12Z

🦋 Changeset detected

Latest commit: 9e7dab9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dhruv7539 · 2026-02-27T19:30:30Z

Addressed both actionable comments in the latest push (8ae0df1):\n- fixed wiring in custom-build path to use \n- added a Wrangler patch changeset ()

dhruv7539 · 2026-02-27T19:30:38Z

Addressed both actionable comments in the latest push (8ae0df1ef):

fixed jsxFragment wiring in BundlerController custom-build path to use config.build.jsxFragment
added a Wrangler patch changeset (.changeset/quick-keys-smell.md)

workers-devprod · 2026-04-15T06:28:47Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

packages/wrangler/src/tests/api/startDevWorker/BundleController.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/api/startDevWorker/BundlerController.ts: [@cloudflare/wrangler]

devin-ai-integration

Devin Review found 1 new potential issue.

View 7 additional findings in Devin Review.

devin-ai-integration · 2026-04-15T06:35:28Z

 			);
 		});
+
+		test("custom build watcher changes are processed without concurrent custom builds", async () => {


🟡 New test uses global expect instead of test context ({ expect }), violating AGENTS.md rule

The new test at line 258 uses async () => { without destructuring expect from the test context, then calls expect(customBuildErrors).toHaveLength(0) at line 313 using the global expect. This violates the explicit rule in packages/wrangler/AGENTS.md: "Never import expect from vitest — use test context ({ expect }) => {}". Every other test in this file (lines 72, 132, 185, 318, 371, 493, 603, 644) correctly uses the async ({ expect }) => { pattern.

Suggested change

test("custom build watcher changes are processed without concurrent custom builds", async () => {

test("custom build watcher changes are processed without concurrent custom builds", async ({ expect }) => {

Was this helpful? React with 👍 or 👎 to provide feedback.

pkg-pr-new · 2026-04-15T08:26:10Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12704

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12704

miniflare

npm i https://pkg.pr.new/miniflare@12704

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12704

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12704

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12704

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12704

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12704

wrangler

npm i https://pkg.pr.new/wrangler@12704

commit: c5495bd

workers-devprod · 2026-04-20T09:17:16Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

packages/wrangler/src/tests/api/startDevWorker/BundleController.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/api/startDevWorker/BundlerController.ts: [@cloudflare/wrangler]

devin-ai-integration

Devin Review found 1 new potential issue.

View 10 additional findings in Devin Review.

devin-ai-integration · 2026-04-20T09:25:13Z

+			while (this.#pendingCustomBuild) {
+				const nextBuild = this.#pendingCustomBuild;
+				this.#pendingCustomBuild = undefined;
+				await this.#runCustomBuild(
+					nextBuild.config,
+					nextBuild.filePath,
+					nextBuild.buildAborter
+				);


🟡 Stale pending custom build executes its external command when aborter is already aborted

When a config update (#startCustomBuild) occurs while a custom build is pending in the queue, #startCustomBuild at BundlerController.ts:230 aborts this.#customBuildAborter (which is the same AbortController stored in #pendingCustomBuild.buildAborter). However, #runPendingCustomBuilds at line 67-74 does not check buildAborter.signal.aborted before dequeuing and running the stale pending build, and #runCustomBuild at line 88-89 emits a bundleStart event and executes the external build command before checking the abort signal at line 101. This means a build known to be cancelled still runs its external command, emits a spurious bundleStart (without a matching bundleComplete), and if the external command fails, emits a confusing error event to downstream consumers (ProxyController, RuntimeControllers per DevEnv.ts:101-104). Adding an early abort guard would avoid this unnecessary work.

Suggested change

while (this.#pendingCustomBuild) {

const nextBuild = this.#pendingCustomBuild;

this.#pendingCustomBuild = undefined;

await this.#runCustomBuild(

nextBuild.config,

nextBuild.filePath,

nextBuild.buildAborter

);

while (this.#pendingCustomBuild) {

const nextBuild = this.#pendingCustomBuild;

this.#pendingCustomBuild = undefined;

if (nextBuild.buildAborter.signal.aborted) {

continue;

}

await this.#runCustomBuild(

nextBuild.config,

nextBuild.filePath,

nextBuild.buildAborter

);

}

Was this helpful? React with 👍 or 👎 to provide feedback.

dhruv7539 requested a review from a team as a code owner February 27, 2026 18:45

dhruv7539 mentioned this pull request Feb 27, 2026

Prevent custom builds from executing concurrenctly #10944

Open

This comment was marked as resolved.

Sign in to view

petebacondarwin force-pushed the codex/serialize-custom-build-watch-events-10944 branch from 8ae0df1 to 90cb61d Compare April 15, 2026 06:28

petebacondarwin requested a review from workers-devprod as a code owner April 15, 2026 06:28

devin-ai-integration bot reviewed Apr 15, 2026

View reviewed changes

petebacondarwin requested review from a team and vicb and removed request for a team April 15, 2026 06:53

dhruv7539 added 2 commits April 15, 2026 09:18

Serialize custom build watcher events in dev

f4d8c62

Fix jsxFragment config in custom dev bundling

c5495bd

petebacondarwin force-pushed the codex/serialize-custom-build-watch-events-10944 branch from 90cb61d to c5495bd Compare April 15, 2026 08:18

workers-devprod added this to workers-sdk Apr 15, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Apr 15, 2026

Merge branch 'main' into codex/serialize-custom-build-watch-events-10944

9e7dab9

devin-ai-integration bot reviewed Apr 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wrangler] serialize custom build watch events to avoid concurrent runs#12704

[wrangler] serialize custom build watch events to avoid concurrent runs#12704
dhruv7539 wants to merge 3 commits intocloudflare:mainfrom
dhruv7539:codex/serialize-custom-build-watch-events-10944

dhruv7539 commented Feb 27, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

changeset-bot bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

dhruv7539 commented Feb 27, 2026

Uh oh!

dhruv7539 commented Feb 27, 2026

Uh oh!

workers-devprod commented Apr 15, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Apr 15, 2026

Uh oh!

pkg-pr-new bot commented Apr 15, 2026

Uh oh!

workers-devprod commented Apr 20, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	test("custom build watcher changes are processed without concurrent custom builds", async () => {
	test("custom build watcher changes are processed without concurrent custom builds", async ({ expect }) => {

Conversation

dhruv7539 commented Feb 27, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Testing

Added regression test

Uh oh!

changeset-bot bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

This comment was marked as resolved.

Uh oh!

dhruv7539 commented Feb 27, 2026

Uh oh!

dhruv7539 commented Feb 27, 2026

Uh oh!

workers-devprod commented Apr 15, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Apr 15, 2026

Uh oh!

workers-devprod commented Apr 20, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dhruv7539 commented Feb 27, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Feb 27, 2026 •

edited

Loading