Skip to content

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Jan 23, 2026

This broke with the Bazel 9 update.
Drive-by: Clean up coverage configuration – we don't use remote execution so no need to set strategy, put -mllvm option on the same line as following option – this is easier to read since -mllvm can't be used as a standalone option. Also, avoid using settings intended for CI in local coverage builds.

This broke with the Bazel 9 update.
Drive-by: Clean up coverage configuration – we don't use remote execution so no
need to set strategy, put -mllvm option on the same line as following option –
this is easier to read since -mllvm can't be used as a standalone option. Also,
avoid using settings intended for CI in local coverage builds.
@fhanau fhanau requested review from a team as code owners January 23, 2026 22:10
@fhanau fhanau requested a review from npaun January 23, 2026 22:23
@fhanau
Copy link
Contributor Author

fhanau commented Jan 23, 2026

I confirmed locally that this fixes builds that use --config=macos-cross-x86_64, which are currently broken on main which is causing release CI to fail.

@npaun
Copy link
Member

npaun commented Jan 23, 2026

Why do we even support intel macs anymore?

@fhanau
Copy link
Contributor Author

fhanau commented Jan 23, 2026

Why do we even support intel macs anymore?

Except for hiccups like this, the opportunity cost is low – it's trivial to cross-compile with the existing support in Xcode and Bazel. There also seem to be people fond of older OS versions/devices which likely includes Intel devices, recently someone asked about having support for macOS 11 (released 2020, EOL since 2023, we dropped support in 2024). I think we should support Intel Mac for as long as there is OS support for it – the current macOS 26 will be the last release with Intel support, so it might be another 2.5 years unless something makes it more difficult to maintain support.

@fhanau fhanau merged commit 82ef2d0 into main Jan 23, 2026
22 of 23 checks passed
@fhanau fhanau deleted the felix/012326-ci-fix branch January 23, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants