Skip to content

Conversation

@shrima-cf
Copy link
Contributor

…t_gate_wait_attempt parent span

This will help group the lock and wait span from a single request together

I noticed from this span - https://tracing.cfdata.org/trace/000f2d35a668d2bb that the lock_wait and lock_holds are grouped individually, making it hard to tie the hold and wait to a single request. This change will help fix the issue.

…t_gate_wait_attempt parent span

This will help group the lock and wait span from a single request together
@shrima-cf shrima-cf requested review from a team as code owners January 23, 2026 00:03
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.66%. Comparing base (a5c6178) to head (085419c).

Files with missing lines Patch % Lines
src/workerd/io/io-gate.c++ 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5948      +/-   ##
==========================================
- Coverage   69.67%   69.66%   -0.01%     
==========================================
  Files         397      397              
  Lines      105999   106000       +1     
  Branches    17965    17965              
==========================================
- Hits        73853    73846       -7     
- Misses      21351    21358       +7     
- Partials    10795    10796       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants