Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 14, 2026

This pull-request ensures that Rust tests, wd_test and kj_test are generating proper test coverage (and with correct line coverages).

Current state of the test coverage on main branch can be accessed from https://app.codecov.io/gh/cloudflare/workerd

Improvements

Tests done to improve the speed of the test coverage runner:

  • Tested different optimization levels for both deps and actual project.
  • Enabled experimental_split_coverage_postprocessing which had the highest impact on reducing the coverage duration.
  • Experiment with different v8-codegen-opt targets/options.
  • Experiment with different optimization levels

Current Issues

Some ongoing issues with test coverage:

@anonrig anonrig requested review from a team as code owners January 14, 2026 13:50
@codspeed-hq

This comment was marked as off-topic.

@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch 2 times, most recently from da41935 to d4b324c Compare January 14, 2026 14:52
@anonrig anonrig requested a review from a team as a code owner January 14, 2026 14:52
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch 22 times, most recently from 3597eca to 9c70d73 Compare January 15, 2026 20:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.67%. Comparing base (d19e973) to head (e13e91c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5881       +/-   ##
===========================================
+ Coverage   68.10%   69.67%    +1.56%     
===========================================
  Files          29      397      +368     
  Lines        2593   105999   +103406     
  Branches       15    17965    +17950     
===========================================
+ Hits         1766    73853    +72087     
- Misses        827    21351    +20524     
- Partials        0    10795    +10795     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig
Copy link
Member Author

anonrig commented Jan 21, 2026

Rebased and force pushed.

@anonrig
Copy link
Member Author

anonrig commented Jan 21, 2026

Temporarily removed main branch requirement of coverage CI.

@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch from eeca57f to ef22439 Compare January 21, 2026 19:44
@anonrig anonrig requested review from fhanau and mikea January 21, 2026 19:47
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch 6 times, most recently from 43fbbf4 to fc00be3 Compare January 21, 2026 22:07
@anonrig
Copy link
Member Author

anonrig commented Jan 21, 2026

Marking it as draft for now. While reverting the wd_test changes the coverage started failing again. Unfortunately, custom rule doesn't play well with coverage and we need sh_test in order to generate coverage reports correctly. I'll try to find a common ground.

@anonrig anonrig marked this pull request as draft January 21, 2026 22:29
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch from fc00be3 to 3229340 Compare January 21, 2026 22:33
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch from 3229340 to 8d45d41 Compare January 21, 2026 22:35
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch 2 times, most recently from 1b2f2a6 to 783cab5 Compare January 22, 2026 18:21
@anonrig anonrig force-pushed the yagiz/fix-wd-test-test-coverage branch from 783cab5 to fa020ed Compare January 22, 2026 18:29
@anonrig anonrig marked this pull request as ready for review January 22, 2026 18:30
@anonrig
Copy link
Member Author

anonrig commented Jan 22, 2026

I've managed to get things going with the latest commit. I think this is ready to get merged. Let's for the CI to generate a coverage report first.

Copy link
Contributor

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, only suggestion is to check if any tests can be re-enabled now that coverage is a bit less slow.

@anonrig anonrig enabled auto-merge (squash) January 22, 2026 21:23
@anonrig anonrig merged commit a5c6178 into main Jan 22, 2026
34 of 35 checks passed
@anonrig anonrig deleted the yagiz/fix-wd-test-test-coverage branch January 22, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants