use edge-mock instead of service-worker-mock#45
Open
samuelcolvin wants to merge 2 commits intocloudflare:masterfrom
Open
use edge-mock instead of service-worker-mock#45samuelcolvin wants to merge 2 commits intocloudflare:masterfrom
samuelcolvin wants to merge 2 commits intocloudflare:masterfrom
Conversation
Contributor
Author
|
I'm not really clear if I should be including changes to |
|
Nice! Might update the edge-mock version here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose that you suggest the user of
edge-mock(which I've just built) instead ofservice-worker-mock.I've made the necessary changes here for the switch.
A few advantages of
edge-mock:service-workersthe project whichservice-worker-mockis a part of is no longer maintainededge-mockprovides support for KV store mocking out-of-the-boxedge-mockproperly supportsArrayBufferandReadableStreamwhichservice-worker-mockdoes notedge-mockhas close to 100% test coverage and is written in typescriptedge-mockare fully compliant with the types they implement in typescript