Skip to content

Conversation

@sterlingwes
Copy link

Fixes #341 when trying to follow the reset troubleshooting steps and the deploy UI doesn't prompt for all of the GH Action inputs

Copy link
Contributor

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed. Did you deploy wildebeest using the deploy button in the README? It didn't prompt you?

@sterlingwes
Copy link
Author

It didn't, that's the reason I opened this

@xtuc
Copy link
Contributor

xtuc commented Feb 27, 2023

@sterlingwes could you please go on https://deploy.workers.cloudflare.com, clear your browser's cache / cookies and try the deploy button again? the fields should show up.

@sterlingwes
Copy link
Author

I did that as per the linked issue, multiple times. Have you tried yourself?

Used chrome and tried incognito and cache clearing

@xtuc
Copy link
Contributor

xtuc commented Feb 27, 2023

Using chrome:
image

Do you see any errors in the console?

@sterlingwes
Copy link
Author

Thanks for checking

New day, new brain.. and looks like I missed that the deploy button tags on a bunch of query params which are necessary for those fields to show. Those params are stripped from the "done" page URL and they're also not present in the link in the troubleshooting doc, which is I think why I ended up retrying incognito on that link (https://deploy.workers.cloudflare.com/?url=https://github.com/cloudflare/wildebeest)

I'll update this PR to suggest users go back to the deploy button on the Getting Started doc if you think that would be useful?

@xtuc
Copy link
Contributor

xtuc commented Feb 28, 2023

Could you remove the link from the troubleshooting doc and redirect users to the get started guide? So we only have one link and it's the correct one. cc @celso

@sterlingwes
Copy link
Author

sterlingwes commented Feb 28, 2023

In another PR I was asked to squash my commits - have you considered changing the default for the repo to squash on merge? That seems to be the standard nowadays since it encourages PRs to be about one thing (leading to one commit on main, but still allowing for granular commits on the branch and not interrupting the review with force pushes) which is a good practice

Also lowers the contribution barrier to entry.. i find myself less enthused about contributing anything substantial to this repo when it's so much back and forth over smol readme changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Troubleshooting steps are missing something

2 participants