fix: vinext start for Cloudflare App Router worker exports#460
Open
JaredStowell wants to merge 1 commit intocloudflare:mainfrom
Open
fix: vinext start for Cloudflare App Router worker exports#460JaredStowell wants to merge 1 commit intocloudflare:mainfrom
JaredStowell wants to merge 1 commit intocloudflare:mainfrom
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
vinext startfor App Router production builds emitted through@cloudflare/vite-plugin.Reported here: #459
Cloudflare App Router builds can default-export a Worker-style object with
fetch()instead of a plain request handler function.vinext startassumed the default export was always callable, which caused startup to fail with:This change teaches the production server to accept both supported App Router entry shapes:
default (request) => Responsedefault { fetch(request, env, ctx) }It also keeps an explicit error for unsupported export shapes.
Changes
vinext startctx.waitUntil()does not crashVerification
Ran:
pnpm test tests/app-router.test.tspnpm run fmtpnpm run typecheckAlso verified manually with a real Cloudflare App Router build:
examples/benchmarksnode ../../packages/vinext/dist/cli.js start --port 4311GET /returned200 OK