fix: object-form query array serialization in next/link and next/router#457
Open
JaredStowell wants to merge 2 commits intocloudflare:mainfrom
Open
fix: object-form query array serialization in next/link and next/router#457JaredStowell wants to merge 2 commits intocloudflare:mainfrom
JaredStowell wants to merge 2 commits intocloudflare:mainfrom
Conversation
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4330d00bd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix object-form URL serialization so array query values are emitted as repeated params instead of comma-joined strings.
Before:
{ pathname: "/search", query: { tag: ["a", "b"], q: "x" } }/search?tag=a,b&q=xAfter:
/search?tag=a&tag=b&q=xChanges
next/linkandnext/routernext/linktypings to allow array query valuesTesting
pnpm test tests/link.test.tspnpm test tests/shims.test.tspnpm run fmtpnpm run typecheck