fix: Pages prod config headers and redirects after middleware rewrites#448
Open
JaredStowell wants to merge 5 commits intocloudflare:mainfrom
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Pages Router production ordering so
next.config.jsheaders()andredirects()still match against the original request pathname even when middleware rewrites the downstream render target.Previously, Pages prod wrote the middleware rewrite into
resolvedUrl, derivedresolvedPathnamefrom that rewritten URL, and then fed that rewritten pathname intomatchHeaders()andmatchRedirect(). That caused config headers/redirects to run against the middleware target instead of the pre-middleware request path.This change updates both Pages production paths to preserve the original normalized
pathnamefor config header/redirect matching while continuing to useresolvedUrl/resolvedPathnamefor downstream rewrites, API routing, and page rendering.Changes
pathnamefor:matchHeaders()matchRedirect()headers()still applying after a middleware rewriteredirects()still winning before a middleware rewrite targetTesting
pnpm test tests/pages-router.test.ts tests/deploy.test.ts tests/entry-templates.test.tspnpm run fmtpnpm run typecheck