fix: App Router route-group and slot collision#447
Open
JaredStowell wants to merge 2 commits intocloudflare:mainfrom
Open
fix: App Router route-group and slot collision#447JaredStowell wants to merge 2 commits intocloudflare:mainfrom
JaredStowell wants to merge 2 commits intocloudflare:mainfrom
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix App Router collision handling when multiple filesystem entries resolve to the same visible URL.
This changes route discovery and validation to:
/fooand/foo/as the same route during validationroute.tshandlersDetails
In
app-router.ts:ownerDirmetadata(slot name, owner dir)instead of slot name aloneIn
route-validation.ts:Tests
Added regressions for:
(a)/aboutvs(b)/aboutroute.tsVerification
Passed:
pnpm test tests/route-sorting.test.tspnpm test tests/routing.test.tspnpm test tests/app-router.test.tspnpm run fmtpnpm run typecheck