-
Notifications
You must be signed in to change notification settings - Fork 221
feat: add create-vinext-app scaffolding CLI #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Divkix
wants to merge
9
commits into
cloudflare:main
Choose a base branch
from
Divkix:feat/create-vinext-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,245
−28
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bf46d29
feat: add create-vinext-app scaffolding CLI
Divkix 4b73bc3
fix(create-vinext-app): use vinext entry instead of missing worker/in…
Divkix 9b700ce
fix(create-vinext-app): extract basename from absolute paths on Windows
Divkix 82f4cfd
fix(vinext): pre-bundle React CJS packages for Cloudflare worker envi…
Divkix 6a54993
ci(create-vinext-app): add pages-router template to integration test …
Divkix aed831e
fix(create-vinext-app): handle "." project name and clean up validation
Divkix e3d3255
fix(create-vinext-app): address PR review feedback
Divkix 12e6bbf
fix(vinext): restore React CJS pre-bundling for Cloudflare worker env…
Divkix 2a0664c
style(vinext): apply oxfmt formatting
Divkix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| { | ||
| "ignorePatterns": ["fixtures/ecosystem/**", "tests/fixtures/ecosystem/**", "examples/**"] | ||
| "ignorePatterns": [ | ||
| "fixtures/ecosystem/**", | ||
| "tests/fixtures/ecosystem/**", | ||
| "examples/**", | ||
| "packages/create-vinext-app/templates/**" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "name": "create-vinext-app", | ||
| "version": "0.0.1", | ||
| "description": "Scaffold a new vinext project targeting Cloudflare Workers", | ||
| "keywords": [ | ||
| "cloudflare", | ||
| "create", | ||
| "next", | ||
| "scaffold", | ||
| "vinext", | ||
| "vite", | ||
| "workers" | ||
| ], | ||
| "license": "MIT", | ||
| "bin": { | ||
| "create-vinext-app": "dist/index.js" | ||
| }, | ||
| "files": [ | ||
| "dist", | ||
| "templates" | ||
| ], | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "pretest": "tsc", | ||
| "test": "vitest run", | ||
| "test:watch": "vitest" | ||
Divkix marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "dependencies": { | ||
| "@clack/prompts": "^0.10.0" | ||
| }, | ||
| "devDependencies": { | ||
| "typescript": "^5.8.2", | ||
| "vitest": "^3.2.1" | ||
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passes an absolute path as the positional arg.
This feeds
${{ runner.temp }}/cva-testas the project name. The code atindex.ts:140correctly handlespath.isAbsolute()by extracting the basename. However, the resultingpackage.jsonwill have"name": "cva-test"and the worker name will be"cva-test". That's fine and works, but it's worth noting that this CI step is exercising the absolute-path code path, not the typical user flow ofcreate-vinext-app my-app.Consider adding a second test that uses a plain name (the typical user flow) to ensure both paths are covered in CI.