fix: Dockerfile supports arm64 Node download #45
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd0xdev
force-pushed
the
fix/dockerfile-arm64-node
branch
2 times, most recently
from
3147a64 to
7542e7f
Compare
Select the correct Node.js binary tarball based on dpkg architecture. - amd64 -> linux-x64 - arm64 -> linux-arm64 This fixes exec format errors when building the sandbox container on arm64 hosts.
sd0xdev
force-pushed
the
fix/dockerfile-arm64-node
branch
from
7542e7f to
15b433c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Dockerfile previously hardcoded
linux-x64in the Node.js binary download URL. On arm64 hosts this can lead to anexec format errorduring the image build.This change selects the correct Node.js tarball based on
dpkg --print-architecture:amd64->linux-x64arm64->linux-arm64Unsupported architectures fail fast with a clear error.
Test plan
docker build -t moltworker-test .docker build -t moltworker-test .node --versionsucceeds in the built image