feat(cloudflare-tunnel): add option to disable default 404#69
Open
lexfrei wants to merge 1 commit intocloudflare:mainfrom
Open
feat(cloudflare-tunnel): add option to disable default 404#69lexfrei wants to merge 1 commit intocloudflare:mainfrom
lexfrei wants to merge 1 commit intocloudflare:mainfrom
Conversation
Signed-off-by: Aleksey Sviridkin <f@lex.la>
lexfrei
changed the title
Gerarddp
approved these changes
May 13, 2024
Author
|
currently, you can use chart with this fix from my repo: https://lexfrei.github.io/charts |
|
I am currently hitting the same issue. Given this is a configuration you can pass, it won't break existing installations. Is there anything missing that prevents this moving forward? |
Author
|
@renan this repo looks abandoned. Just use my fork as drop-in replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced an issue with preset wildcard rule.
So, here is a fix for this issue.
Previous behaviour is saved, chart version is bumped.