fix(ai-chat): wrap onRequest in constructor to guarantee /get-messages works#953
Open
mattzcarey wants to merge 5 commits intomainfrom
Open
fix(ai-chat): wrap onRequest in constructor to guarantee /get-messages works#953mattzcarey wants to merge 5 commits intomainfrom
mattzcarey wants to merge 5 commits intomainfrom
Conversation
…s works Move /get-messages handling from the prototype override to a constructor wrapper. This ensures the endpoint works even if users override onRequest without calling super.onRequest(). Not a breaking change - fixes broken code without affecting working code.
🦋 Changeset detectedLatest commit: 7e5a940 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move /get-messages handling from the prototype override to a constructor wrapper. This ensures the endpoint works even if users override onRequest without calling super.onRequest().
Why this is needed
When users override
onRequestin their AIChatAgent subclass without callingsuper.onRequest(), the/get-messagesendpoint doesn't work, causing messages to not persist on page reload.Changes
onRequestthat handles/get-messagesbefore delegating to user codeoverride onRequest()methodNote to reviewer
Pretty sure this isnt a breaking change.
super.onRequest(): Same behaviorsuper.onRequest(): Was broken (404), now fixedTest plan