Add post-hook functionality when finalizing osmorphing#459
Merged
Conversation
Dany9966
requested changes
Jun 24, 2026
fabi200123
force-pushed
the
add-post-hook-osmorphing
branch
from
3169b24 to
9423801
Compare
Dany9966
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic of execute grub update in osmorphing so that this is only ran in the
post_package_installbased on a flag configured viaself._schedule_grub2_update().Before, any grub related modification is followed by an update grub command (or grub-mkconfig). If there were multiple of them, we would basically run redundant updates and only make the osmorphing process take longer, as some of these processes can take up to minutes (especially when doing update-initramfs or dracut updates).