Change set_dhcp option to create nmconnection files for Redhat 9+#444
Merged
Dany9966 merged 1 commit intoJun 29, 2026
Merged
Conversation
Dany9966
requested changes
May 27, 2026
fabi200123
force-pushed
the
move-nmconnection-fix-to-core
branch
2 times, most recently
from
dac4f26 to
8c5ce0f
Compare
Dany9966
requested changes
Jun 16, 2026
fabi200123
force-pushed
the
move-nmconnection-fix-to-core
branch
3 times, most recently
from
2014d68 to
c4183b6
Compare
Dany9966
requested changes
Jun 24, 2026
| self.network_scripts_path) | ||
| if ifcfg_files: | ||
| ifcfgs_ethernet = self._get_ifcfgs_by_type( | ||
| ifcfgs_ethernet = self.osmorphing_tool._get_ifcfgs_by_type( |
Contributor
There was a problem hiding this comment.
As a future improvement (in another PR), can you please make the netpreservers NOT read through the files twice? Maybe just re-use the object in the factory instead of the class, or return this collection of interface files instead of a bool value, and pass it down to parse_network.
fabi200123
force-pushed
the
move-nmconnection-fix-to-core
branch
from
c4183b6 to
6963f40
Compare
Dany9966
requested changes
Jun 26, 2026
fabi200123
force-pushed
the
move-nmconnection-fix-to-core
branch
2 times, most recently
from
5573f27 to
cbdde8f
Compare
fabi200123
force-pushed
the
move-nmconnection-fix-to-core
branch
from
cbdde8f to
65ecb6c
Compare
Dany9966
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when the set_dhcp option is set to true, it creates ifcfg files for all redhat versions.
From Rhel8, we also require to have the
NM_CONTROLLED=yes, since in this version there is support for nmconnection files.From Rhel9, it has changed from ifcfg files to nmconnection files, thus this PR adds a template and creates nmconnection files for all distros that have minimum version 9.