Conversation
shikanime
force-pushed
the
pr1980
branch
2 times, most recently
from
0798bdd to
2edf706
Compare
shikanime
force-pushed
the
pr1958
branch
2 times, most recently
from
31f5dfc to
6aef06f
Compare
shikanime
force-pushed
the
pr1980
branch
2 times, most recently
from
786f110 to
56c2848
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
11 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I37010cbbfad6e0ac2dbd2adb8e560be36a6a6964
|
🤖 Hey ! The security scan report for the current pull request is available here. |
3 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
2 New Issues
0 Fixed Issues
0 Accepted Issues
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
Des questions, pas des problèmes, donc LGTM 🚀
|
|
||
| const server = setupServer() | ||
| const nexusAdminPassword = faker.internet.password() | ||
| const basicAuth = `Basic ${Buffer.from(`admin:${nexusAdminPassword}`, 'utf8').toString('base64')}` |
There was a problem hiding this comment.
nitpick: Chuis un peu d'accord avec Sonarqube sur le principe, mais bon là c'est suffisament élémentaire pour ne pas être un problème
| @@ -0,0 +1,33 @@ | |||
| // Registry plugin identification | |||
| export const REGISTRY_PLUGIN_NAME = 'harbor' | |||
There was a problem hiding this comment.
thought: Finalement pourquoi on n'appellerait pas le module harbor plutôt que registry ? On a des variables, de la log, etc. qui disent "Harbor", mais le module/service s'appelle registry ? On rajoute de la confusion, je trouve 🤔
| expect(client.deleteIdentityGroupName).toHaveBeenCalledWith(`project-${project.slug}-devops`) | ||
| expect(client.deleteIdentityGroupName).toHaveBeenCalledWith(`project-${project.slug}-developer`) | ||
| expect(client.deleteIdentityGroupName).toHaveBeenCalledWith(`project-${project.slug}-readonly`) | ||
| expect(client.deleteIdentityGroupName).toHaveBeenCalledWith(`project-${project.slug}-security`) |
There was a problem hiding this comment.
thought: Ptet qu'à un moment donné je me demande si on ne s'interdirait les toHaveBeenCalledWith. J'ai toujours eu la sensation que si on se sent obligés d'utiliser ça, c'est qu'on a un problème soit de testabilité du SUT, soit qu'on ne teste pas au bon niveau (trop abstrait ou pas assez)
2 participants
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Change-Id: I37010cbbfad6e0ac2dbd2adb8e560be36a6a6964
Stack created with Sapling. Best reviewed with ReviewStack.