Refactor kubeconfig: provider/consumer split, kubeconfig_generator, tests#1457
Open
anniegracehu wants to merge 1 commit intocloud-ark:masterfrom
Open
Refactor kubeconfig: provider/consumer split, kubeconfig_generator, tests#1457anniegracehu wants to merge 1 commit intocloud-ark:masterfrom
anniegracehu wants to merge 1 commit intocloud-ark:masterfrom
Conversation
- Add kubeconfig_generator.py and kubeconfig_helpers.py - provider-kubeconfig: fix namespace create bug, add -p permissionfile - Unit tests for build_kubeconfig_dict, CLI parity, provider/consumer split - Integration tests for provider and consumer equivalence (skipped without cluster)
| get_ns = "kubectl get ns " + namespace + kubeconfigString | ||
| out, err = run_command(get_ns) | ||
| if 'not found' in (out or '') or 'not found' in (err or ''): | ||
| run_command("kubectl create ns " + namespace + kubeconfigString) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors kubeconfig generation with a clear provider/consumer split, adds a new
kubeconfig_generatorimplementation, and introduces tests.Changes
kubectl get nsinstead ofkubectl create ns)Design
provider-kubeconfig.pystays as the main script for backward compatibilitykubeconfig_generator.pyis the refactored implementation; can be used as an alternativeTesting
python -m unittest tests.test_kubeconfig_generator -v
With cluster (minikube):
KUBECONFIG=~/.kube/config python -m unittest tests.test_kubeconfig_generator -v