Skip to content

Refactor/csharp sdk remotetablename public #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GEFNENEN wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Refactor/csharp sdk remotetablename public #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de3342
Change access modifier of RemoteTableName property
GEFNENEN Mar 27, 2026
afea5f5
Change RemoteTableName property from protected to public
GEFNENEN Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/codegen/src/csharp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ impl Lang for Csharp<'_> {
indented_block(output, |output| {
writeln!(
output,
"protected override string RemoteTableName => \"{}\";",
"public override string RemoteTableName => \"{}\";",
table.name
);
writeln!(output);
Expand Down
2 changes: 1 addition & 1 deletion sdks/csharp/src/Table.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ internal class ParsedTableUpdate : IParsedTableUpdate
internal List<Row>? EventRows;
}

protected abstract string RemoteTableName { get; }
public abstract string RemoteTableName { get; }
string IRemoteTableHandle.RemoteTableName => RemoteTableName;

/// <summary>
Expand Down