Make /v1/database/:name/call/:func call procedures too, remove procedure route #3883
Conversation
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Code looks good. I tested locally and was able to call procedures. I'd like to see a smoketest added, please - something trivial that just calls a procedure and inspects its return value.
|
It sounds like this is an API break - does that mean that older versions of the CLI will not be able to |
| .after_help("Run `spacetime help call` for more detailed information.\n") | ||
| } | ||
|
|
||
| enum CallResult<'a> { |
There was a problem hiding this comment.
it looks like this is just a description of what the call result will be, not the result itself, is that right?
| fn add_reducer_ctx_to_err(error: &mut String, module_def: &ModuleDef, reducer_name: &str) { | ||
| let mut reducers = module_def | ||
| /// decorate `error` with more helpful info about reducers and procedures. | ||
| fn add_reducer_procedure_ctx_to_err(error: &mut String, module_def: &ModuleDef, reducer_name: &str) { |
There was a problem hiding this comment.
did you test some of these error cases as well? either manually or with a smoketest?
I don't think that's true. When calling reducers, the return format of the route is unchanged, to the best of my ability to determine. It's only when calling a procedure that the route returns something different, and the old CLI won't do that because it checks the moduledef first. |
Okay, great. I was just going off of this description:
|
Description of Changes
Closes #3659
API and ABI breaking changes
Remove route and alter the semantics of the
callroute on both server andcliExpected complexity level and risk
1
Testing
proceduresand observe calling theclithe result is print.