Closed
Conversation
This was referenced Dec 18, 2020
GradedJestRisk
force-pushed
the
master
branch
from
ef87279 to
6b0fb4d
Compare
GradedJestRisk
force-pushed
the
master
branch
from
6b0fb4d to
98a1148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
PLV8_VERSION=2.3.15Note: CI will go on failing until PR #40 is merged
The local build
docker build --tag plv8:13-2 .failedI hinted at this issue
The CI build failed even with older versions with
plv8.cc:13:19: error: ‘namespace_’ does not name a type#define namespace namespace_I don't know c++, but a similar error popped up in 2016 here