Skip to content

fix: kebab-casing should work in multicursor completion #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
action-hong wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: kebab-casing should work in multicursor completion #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ export function createBracketCompletionItem (className: string, position: Positi
completionItem.detail = `['${className}']`;
completionItem.documentation = "kebab-casing may cause unexpected behavior when trying to access style.class-name as a dot notation. You can still work around kebab-case with bracket notation (eg. style['class-name']) but style.className is cleaner.";
completionItem.insertText = `['${className}']`;
completionItem.additionalTextEdits = [new TextEdit(new Range(new Position(position.line, position.character - 1),
new Position(position.line, position.character)), '')];
// .className -> ['className']
// set filterText to match .className
// https://github.com/microsoft/vscode/issues/113551#issuecomment-754158355
completionItem.filterText = `.${className}`
completionItem.range = new Range(new Position(position.line, position.character - 1), position);
return completionItem;
}